Skip to content

Move scene version collector earlier - #1986

Draft
moonyuet wants to merge 6 commits into
developfrom
enhancement/move_collect_scene_version_earlier
Draft

Move scene version collector earlier#1986
moonyuet wants to merge 6 commits into
developfrom
enhancement/move_collect_scene_version_earlier

Conversation

@moonyuet

@moonyuet moonyuet commented Aug 6, 2026

Copy link
Copy Markdown
Member

Changelog Description

Move CollectSceneVersion earlier regarding to ynput/ayon-aftereffects#90

Additional info

Draft PR for ongoing discussion.

Testing notes:

  1. Add the host into ayon+settings://core/publish/CollectSceneVersion if it is not the default host.
  2. Testing publishing or any kind

@moonyuet
moonyuet requested review from BigRoy and iLLiCiTiT August 6, 2026 08:59
@moonyuet moonyuet self-assigned this Aug 6, 2026
@moonyuet moonyuet added the type: enhancement Improvement of existing functionality or minor addition label Aug 6, 2026
@ynbot ynbot added the size/XS label Aug 6, 2026
@BigRoy

BigRoy commented Aug 6, 2026

Copy link
Copy Markdown
Member

Note that -0.45 would break things for: TVPaint, Zbrush, Flame, Fusion, ComfyUI. See the list here: ynput/ayon-aftereffects#90 (comment)

@moonyuet

moonyuet commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

Note that -0.45 would break things for: TVPaint, Zbrush, Flame, Fusion, ComfyUI. See the list here: ynput/ayon-aftereffects#90 (comment)

5bf0447

@BigRoy

BigRoy commented Aug 6, 2026

Copy link
Copy Markdown
Member

Note that -0.45 would break things for: TVPaint, Zbrush, Flame, Fusion, ComfyUI. See the list here: ynput/ayon-aftereffects#90 (comment)

Based on this comment @moonyuet it should've been later, not earlier ;)

As stated there:

Meaning that we can nudge CollectSceneVersion to -0.39. Yet I also think pushing those host that can to -0.5 or at least -0.49 could be nice, just so CollectSceneVersion could perhaps be fine at -0.45

Until we start moving the currentFile data to be collected earlier in those DCCs.

@iLLiCiTiT

iLLiCiTiT commented Aug 6, 2026

Copy link
Copy Markdown
Member

If I understand correcly, this PR was added because the AE plugin does use currentFile and version? Is it used for any logic, or just as an "metadata"? If it is used as a metadata then just fill it later during publishing...

We need created instances with filled product base type, basic families and correct folder and task. Everything else can be collected later.

@moonyuet

moonyuet commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

If I understand correcly, this PR was added because the AE plugin does use currentFile and version? Is it used for any logic, or just as an "metadata"? If it is used as a metadata then just fill it later during publishing...

Yes It is moved earlier because "version" from CollectAERender is using "version" from context data and they use it to create AERenderInstance

@iLLiCiTiT

Copy link
Copy Markdown
Member

Yes It is moved earlier because "version" from CollectAERender is using "version" from context data and they use it to create AERenderInstance

So it is used only as a metadata and does not really have to filled in the plugin.

@moonyuet

Copy link
Copy Markdown
Member Author

Yes It is moved earlier because "version" from CollectAERender is using "version" from context data and they use it to create AERenderInstance

So it is used only as a metadata and does not really have to filled in the plugin.

I would say yes. It is only used for filling version attribute lasted in RenderInstance. If we dont fill in the version data I assume it would be errored out for RenderInstance as the version attribute doesn't default to any value.
Guess it would be good enough to just move the ordering from CollectRender in AE side? @BigRoy @iLLiCiTiT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants