Remove hosts and families filtering from ExtractThumbnail - #1863
Draft
BigRoy wants to merge 1 commit into
Draft
Conversation
Member
|
NOTE: We should also find out why the representations are being removed here if they have I think the other DCCs are using in-DCC logic for thumbnail extraction. E.g. maya viewport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Remove
hostsandfamiliesfiltering fromExtractThumbnailAdditional info
Follow up to: #1860 (comment)
This will need some follow up changes. The class name for example is not unique. Same class name exists in:
This will also need thorough testing whether it does not conflict with logic in certain DCCs like e.g. the ones mentioned here that also roll their own Extract Thumbnail plug-in.
Testing notes: