Add a Location to every function - #28
Merged
Merged
Conversation
This reverts commit fe44ba1.
This is a bit icky, but right now yk doesn't support an important performance edge case (and the fix is sophisticated, and will take time). This is a reasonable intermediate step to getting better performance.
ltratt
enabled auto-merge
August 13, 2026 09:38
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done a lot of analysis over the past couple of days and the good news is that I know how to allow inlining of Python functions in ykmicropython, but the bad news is that there are some performance edge cases that will take a lot of work to fix in yk. I will get to those one day, but for now, the sensible fix in ykmicropython is to add a
Locationto every function. Once that's done, our "is it recursive?" check is pointless, and just slows the interpreter down, so off with its head.