You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The adapter has been exercised against a GKE Agent Sandbox warm pool. The final compatibility fix uses the request-object API required by @kubernetes/client-node 1.4 for custom resource create/get/delete calls.
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.
Updated the GKE adapter after validating against a live managed Agent Sandbox CRD. The served v1alpha1 SandboxClaim schema requires spec.sandboxTemplateRef; the equivalent claim passed server-side dry-run. This replaces the rejected warm-pool-specific claim fields while preserving the separately managed warm pool that references the same template. Local full tests (928), typecheck, and lint pass.
Live GKE execution exposed a non-root workspace issue after claim provisioning was fixed: managed Agent Sandbox mounts /home/agent writable to uid/gid 1000, but preserves the image-baked /home/agent/workspace as root-owned 0755. Updated the GKE adapter to create /home/agent/qm-workspace at runtime, avoiding an init container or privilege escalation. Manual live write probe and focused adapter tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a provider-native GCP runtime path for QM:
The adapter does not create GKE, Cloud SQL, buckets, IAM, or Secret Manager resources.
Verification
Live validation
The adapter has been exercised against a GKE Agent Sandbox warm pool. The final compatibility fix uses the request-object API required by @kubernetes/client-node 1.4 for custom resource create/get/delete calls.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.