-
Notifications
You must be signed in to change notification settings - Fork 57
Pass a per-run framework context/state through the Session to every framework adapter #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
induwara-yaala
wants to merge
9
commits into
develop
Choose a base branch
from
526-ak-164-framework-context-support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7712ad5
feat: Implement per-run framework context/state support in Session fo…
induwara-yaala f604941
feat: Add support for per-run framework context/state across multiple…
induwara-yaala f3788cc
chore: Lint
induwara-yaala 7483a29
feat: Enhance framework context handling with error logging and type …
induwara-yaala cc4a2b0
feat: Enhance Google ADK session state handling with caller key seedi…
induwara-yaala 9dd72b8
feat: Add demo for per-run framework context/state with Google ADK
induwara-yaala 45799c5
refactor: Rename logger variable and update framework context failure…
induwara-yaala ce85aa4
refactor: Simplify framework context handling and improve documentation
induwara-yaala b1f1595
refactor: Initialize prompt variable in langgraph.py for improved cla…
induwara-yaala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] Dropping
import readlineremoves line-editing/history for every interactive CLI user, silently and out of scope for this PR.readlinehas a documented import-time side effect (# Enables line editing and history features for input() in the CLI) that patchesinput()process-wide. Removing it disables arrow-key history and line editing for allCLIusers, not just the newframework_contextdemos — and neitherdesign.mdnorspec.mdmentions a CLI change at all._ainput, a daemon-threadinput()wrapper bridged back viacall_soon_threadsafe) is a legitimate way to stop the interactive loop from blocking the event loop, but it's a nontrivial concurrency primitive with no test coverage anywhere inak-py/tests/(there's notest_cli.py), and no explanation in the PR of why the CLI needed to change for a session-key feature.examples/cli/adk_context(or the other_contextdemos), say so explicitly in the PR description/spec and restorereadline(importing it doesn't require callinginput()from the main thread — the hook is process-wide) so history/editing isn't lost.