schedules: added producer and consumer fusion to descript - #127
Open
liamsemeria wants to merge 1 commit into
Open
schedules: added producer and consumer fusion to descript#127liamsemeria wants to merge 1 commit into
liamsemeria wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
guillon
requested changes
Sep 4, 2026
guillon
left a comment
guillon
left a comment
Member
There was a problem hiding this comment.
Could you also augment the descript pretty print and update the test:
tests/filecheck/schedules/test_get_descript.py ?
liamsemeria
force-pushed
the
dev/tvm-refactor
branch
from
September 4, 2026 12:35
0758b25 to
4959314
Compare
Contributor
Author
updated the tests for pretty print. |
guillon
requested changes
Sep 4, 2026
| # CHECK-NEXT: conv[v_b, v_h, v_w, v_f] = conv[v_b, v_h, v_w, v_f] + pad[v_b, v_h * 2 + v_r, v_w * 2 + v_s, v_c] * _1[v_r, v_s, v_c, v_f] | ||
| # CHECK-NEXT: O = sch.get_sblock("conv") | ||
| # CHECK-NEXT: b, h, w, r, s, c, f, = sch.get_loops(O) | ||
| # CHECK-NEXT: sch.reorder(b, h, w, r, s, c, f) |
Member
There was a problem hiding this comment.
Actually I do not see fusion directive in the TVM schedule. And the generated TIR is not fuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Descript didn't have fusion yet
Description
Adds producer and consumer fusion to descript.
There are tests for both backends for producer fusion.
When MLIR consumer fusion gets merged I'll add a descript test, as of now only TVM has a consumer fusion test.