Stop local paper renders from being stageable into a public repo - #621
Open
xmap wants to merge 1 commit into
Open
Stop local paper renders from being stageable into a public repo#621xmap wants to merge 1 commit into
xmap wants to merge 1 commit into
Conversation
Reviewing a paper render rasterizes its PDF into page images under tmp/pdfs/. Four such folders had accumulated, 84 page images across four unpublished papers, and git reported the directory as untracked rather than ignored. Untracked is a weaker guarantee than it looks. The papers themselves are protected because papers/*/ is ignored, but their renders sit at the repo root and inherit none of that, so a git add -A would stage unpublished paper pages into a public repo. Ignoring tmp/ closes the gap at the directory that keeps getting recreated, rather than relying on whoever runs the next render to clean up after it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
tmp/to.gitignore.Why
Reviewing a paper render rasterizes its PDF into page images under
tmp/pdfs/. Four such folders had accumulated locally, 84 page imagesacross four unpublished papers, and git reported the directory as
untracked rather than ignored.
Untracked is a weaker guarantee than it looks. The papers themselves are
protected because
papers/*/is ignored, but their renders sit at the reporoot and inherit none of that protection. A
git add -Awould stageunpublished paper pages into a public repo, which is exactly what the
papers-stay-local rule exists to prevent.
Ignoring
tmp/closes the gap at the directory that keeps gettingrecreated, rather than relying on whoever runs the next render to clean up
after it.
The accumulated renders are separately being deleted locally. They are
fully regenerable from each paper's
main.pdf, so nothing original islost.
🤖 Generated with Claude Code