fix(provider): omit embedding and reranker slugs from Codex /model - #82
Open
xjoker wants to merge 1 commit into
Open
fix(provider): omit embedding and reranker slugs from Codex /model#82xjoker wants to merge 1 commit into
xjoker wants to merge 1 commit into
Conversation
Small-gateway wholesale injection still fills /model, but embedding and reranker ids cannot run Codex. A slug the user saved as --model is kept. Co-authored-by: lolitaupdate <lolitaupdate@gmail.com>
xjoker
marked this pull request as ready for review
August 27, 2026 07:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Z.ai (and similar small gateways) return embedding/reranker ids in
/models. Wholesale catalog injection put those slugs into Codex/model, where they cannot run the Responses loop.This filters them out of wholesale injection only. A slug the user saved as
--modelis still injected.Token match (case-insensitive, split on non-alphanumeric):
embed,embedding,embeddings,rerank,reranker,reranking.The 48-item wholesale threshold still uses the unfiltered remote length.
Test plan
cargo test --lib wholesale_injection_drops_embedding_and_reranker_slugs a_saved_embedding_slug_stays_in_the_catalog chat_slugs_that_only_contain_embed_as_a_longer_word_are_keptcargo clippy --all-targets -- -D warnings