Bounds-check pivptr in *pivotL.c before accessing lsub_ptr on singular matrix - #178
Merged
Merged
Conversation
…ingular matrix When the matrix is singular (pivmax == 0.0), pivptr may be out of bounds for lsub_ptr (pivptr >= nsupr). Add a guard to use diagind as the pivot row when pivptr is out of range. Upstreamed from SciPy, which has carried this patch for a long time. Also cleans up some code that was ifdef'd out already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the matrix is singular (
pivmax == 0.0),pivptrmay be out of bounds forlsub_ptr(pivptr >= nsupr). Add a guard to usediagindas the pivot row whenpivptris out of range.Upstreamed from SciPy, which has carried this patch for a long time.
Also cleans up some code that was
ifdef'd out already.Split off from PR gh-174, since that one is current blocked on performance-related concerns of unrelated commits.