Skip to content

docs(agents): define shipping workflow - #7

Merged
xdanger merged 1 commit into
mainfrom
docs/git-workflow-shipping
Jul 30, 2026
Merged

docs(agents): define shipping workflow#7
xdanger merged 1 commit into
mainfrom
docs/git-workflow-shipping

Conversation

@xdanger

@xdanger xdanger commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • consolidate Git guidance into one lifecycle-oriented workflow
  • make “ship the changes/branch” authorize validation, push, PR shepherding, merge, and cleanup
  • document how upstream test failures interact with the strict GREEN gate

Validation

  • prettier --check agents/AGENTS.md
  • git diff --check
  • repository has no configured automated test suite

- 📝 make ship requests cover validation, PR shepherding, merge, and cleanup
@xdanger xdanger self-assigned this Jul 30, 2026
@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown

Greptile Summary

Consolidates the repository’s Git guidance into a lifecycle-oriented shipping workflow.

  • Defines “ship” requests as authorization to validate, commit, push, open and shepherd a PR, merge after the strict GREEN gate, and clean up.
  • Clarifies when pre-existing upstream test failures are non-blocking.
  • Reorganizes branch, commit, pull-request, merge, and cleanup guidance.

Confidence Score: 5/5

The documentation-only change appears safe to merge.

The revised guidance consistently defines the shipping lifecycle, preserves the strict GREEN merge gate, and explicitly limits non-blocking local failures to verified pre-existing upstream failures.

Important Files Changed

Filename Overview
agents/AGENTS.md Reorganizes and expands agent Git workflow documentation without introducing a concrete conflicting or unsafe instruction.

Reviews (1): Last reviewed commit: "📝 docs(agents): define shipping workflo..." | Re-trigger Greptile

@xdanger
xdanger requested a review from Copilot July 30, 2026 10:01
@xdanger
xdanger merged commit 5de3b3b into main Jul 30, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the agent guidelines to present Git practices as a single, lifecycle-oriented workflow, and clarifies what “ship the changes/branch” authorizes (validation through merge and cleanup), including how to handle upstream test failures under a strict GREEN gate.

This change updates the agent-facing development guidelines to consolidate Git-related instructions into a clearer “workflow” narrative, with an explicit “Shipping” lifecycle that defines the expected end-to-end behavior when asked to ship work.

Changes:

  • Reorganized Git guidance into a “Git Workflow” section with clear subsections (branches/worktrees, commits, shipping, PR/merge/cleanup).
  • Defined “ship the changes/branch” as an explicit mandate covering validation, push, PR shepherding, merge, and cleanup.
  • Tightened wording around post-merge cleanup and the strict pr-shepherd GREEN gate expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xdanger
xdanger deleted the docs/git-workflow-shipping branch July 30, 2026 10:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ad08032d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread agents/AGENTS.md
## PR Reviews
**Shipping**

- Treat “ship the changes,” “ship the branch,” and equivalent requests as an explicit, fully autonomous mandate to complete the entire Git workflow. Do not stop after committing, pushing, or opening the PR.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the lint-failure decision gate

When the required test suite or PR checks report a lint failure, this fully autonomous mandate conflicts with the repository policy requiring the agent to report the rule and wait for the user to decide. The invoked pr-shepherd workflow explicitly directs the agent to fix lint failures, so a “ship” request now either pauses unexpectedly or bypasses that approval gate; clarify which instruction takes precedence.

AGENTS.md reference: AGENTS.md:L69-L71

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants