docs(agents): define shipping workflow - #7
Conversation
- 📝 make ship requests cover validation, PR shepherding, merge, and cleanup
|
| Filename | Overview |
|---|---|
| agents/AGENTS.md | Reorganizes and expands agent Git workflow documentation without introducing a concrete conflicting or unsafe instruction. |
Reviews (1): Last reviewed commit: "📝 docs(agents): define shipping workflo..." | Re-trigger Greptile
There was a problem hiding this comment.
Pull request overview
This PR restructures the agent guidelines to present Git practices as a single, lifecycle-oriented workflow, and clarifies what “ship the changes/branch” authorizes (validation through merge and cleanup), including how to handle upstream test failures under a strict GREEN gate.
This change updates the agent-facing development guidelines to consolidate Git-related instructions into a clearer “workflow” narrative, with an explicit “Shipping” lifecycle that defines the expected end-to-end behavior when asked to ship work.
Changes:
- Reorganized Git guidance into a “Git Workflow” section with clear subsections (branches/worktrees, commits, shipping, PR/merge/cleanup).
- Defined “ship the changes/branch” as an explicit mandate covering validation, push, PR shepherding, merge, and cleanup.
- Tightened wording around post-merge cleanup and the strict
pr-shepherdGREEN gate expectations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ad08032d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## PR Reviews | ||
| **Shipping** | ||
|
|
||
| - Treat “ship the changes,” “ship the branch,” and equivalent requests as an explicit, fully autonomous mandate to complete the entire Git workflow. Do not stop after committing, pushing, or opening the PR. |
There was a problem hiding this comment.
Preserve the lint-failure decision gate
When the required test suite or PR checks report a lint failure, this fully autonomous mandate conflicts with the repository policy requiring the agent to report the rule and wait for the user to decide. The invoked pr-shepherd workflow explicitly directs the agent to fix lint failures, so a “ship” request now either pauses unexpectedly or bypasses that approval gate; clarify which instruction takes precedence.
AGENTS.md reference: AGENTS.md:L69-L71
Useful? React with 👍 / 👎.
Summary
Validation
prettier --check agents/AGENTS.mdgit diff --check