Improve SVG Icon block for 1.4.8#50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
block.jsonwhile preserving the existing block name and shortcodepx,em, andremsizing, native color/spacing/anchor/class supports, original-color and monochrome modes, and decorative/informative accessibility controlsWhy
The previous block eagerly loaded the full icon library, hand-maintained block metadata, forced all path fills, offered only pixel sizing, and always hid icons from assistive technology. Its regex-based renderer could also duplicate root attributes and SVG definition IDs.
Validation
composer check(PHP lint, WordPress Coding Standards, 24 PHPUnit tests / 94 assertions)node --check