Fix PWA offline precaching on fresh installs#49
Merged
Conversation
wpgaurav
marked this pull request as ready for review
July 22, 2026 04:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
functionalities_pwaoption save throughadded_optionRoot cause
The service worker precaches the offline URL with
cache.addAll(), which rejects the previous HTTP 503 response. On a fresh installation, WordPress also firesadded_optioninstead ofupdated_option, so the plugin did not register and flush the new PWA rewrites after the first settings save.Validation
composer check: 19 tests, 69 assertions