Don't forward a stale error_message once a transfer has finished - #40
Open
snugglefluff wants to merge 1 commit into
Open
Don't forward a stale error_message once a transfer has finished#40snugglefluff wants to merge 1 commit into
snugglefluff wants to merge 1 commit into
Conversation
put.io can leave error_message set from a transient issue (e.g. "not enough space") even after the transfer retries and completes on its own. transmission.rs forwarded it unconditionally, so a fully downloaded transfer could still report an error, which makes Sonarr/Radarr mark the queue item "warning" and skip Completed Download Handling - the file never gets imported. Only forward error_message while finished_at is unset, so a real, ongoing error still surfaces but a finished transfer reports clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
put.io can leave error_message set from a transient issue (e.g. "not enough space") even after the transfer retries and completes on its own. transmission.rs forwarded it unconditionally, so a fully downloaded transfer could still report an error, which makes Sonarr/Radarr mark the queue item "warning" and skip Completed Download Handling - the file never gets imported.
Only forward error_message while finished_at is unset, so a real, ongoing error still surfaces but a finished transfer reports clean.