expanded the types to include snaks - #14
Open
wvanderp wants to merge 23 commits into
Open
Conversation
Contributor
|
Hi! Thanks so much for your PR. I guess you saw that we are tracking bugs on phabricator and the ticket assigned to this has been edited into your PR description. We need to find a little time to review this but I hope we can give you some feedback shortly. Cheers! |
wvanderp
commented
Nov 18, 2020
Update ESLint configuration syntax Add CI/CD workflows for testing and publishing Update package configuration and rename package Add Rollup build configuration Add TypeScript generator for language codes Add new language codes to LabelLanguages and MonolingualLanguages Update README with installation and usage instructions
Make optional fields in Item, Mediainfo and WikidataResponse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello,
I was looking for wikidata dataformat types and found this.
I expanded the types by adding the api results from wikidata and then adding stuff till it had no errors.
In this process I lost track of what is wikidata and what is wikibase so that is someting that needs to be looked at.
I also removed some simi types like fingerprintable so if there is still a need for that then ill add it again.
I look forward to hearing what you think of the PR.
-wvdp
Bug: https://phabricator.wikimedia.org/T267904