fix: move pylint disable comments to correct lines in test files - #113
Merged
Merged
Conversation
The `# pylint: disable=import-outside-toplevel` comments were placed on the closing `)` line of multi-line imports, but pylint matches inline disables to the line where the warning is triggered (the `from` line). Moving the comment to the opening `from (` line silences C0415 correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjiDW5hoDgJ6GYZ7tUozim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# pylint: disable=import-outside-toplevelcomments intests/test_compat.pyandtests/test_widgets.pywere placed on the closing)line of multi-line imports.fromline — so the comments were silently ignored andC0415kept firing.from ... (line so pylint actually suppresses them.Both test files now score 10.00/10 (up from 7.98/10).
Generated by Claude Code