Add user-agent support#19
Merged
Merged
Conversation
Kota-Jagadeesh
suggested changes
Jul 20, 2026
|
|
||
| ```php | ||
| $wsApi = new \Wikisource\Api\WikisourceApi(); | ||
| $wgApi->setUserAgent( 'my-example-tool.toolforge.org' ); |
There was a problem hiding this comment.
@samwilson This should be $wsApi instead of $wgApi, otherwise the example won't work :) Thanks
Kota-Jagadeesh
suggested changes
Jul 20, 2026
| $client = new Client(); | ||
| $client = new Client( [ | ||
| 'headers' => [ | ||
| 'User-Agent' => $this->userAgent, |
There was a problem hiding this comment.
Should we also consider sending an Accept: application/sparql-results+xml headerr since this endpoint always expects SPARQL XML responses?
samwilson
commented
Jul 21, 2026
samwilson
left a comment
samwilson
left a comment
Member
Author
There was a problem hiding this comment.
Thanks for reviewing!
I think after upgrading to addwiki v4 we'll be able to pass the user agent through to every API call. But that can be a separate patch.
|
|
||
| ```php | ||
| $wsApi = new \Wikisource\Api\WikisourceApi(); | ||
| $wgApi->setUserAgent( 'my-example-tool.toolforge.org' ); |
| $client = new Client(); | ||
| $client = new Client( [ | ||
| 'headers' => [ | ||
| 'User-Agent' => $this->userAgent, |
Member
Author
|
Oh, actually there were version clashes, might as well do the upgrade now. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.