Feat/cn helper - #418
Open
shakurt wants to merge 6 commits into
Open
Conversation
Local Claude Code session config shouldn't be tracked.
cn.ts imports clsx directly, but it was never added to package.json — it only worked locally because it happened to already be present in node_modules from an unrelated install. A clean install (e.g. CI) can't resolve it. Adding it explicitly and regenerating the lockfile.
shakurt
force-pushed
the
feat/cn-helper
branch
from
August 15, 2026 15:06
b90db25 to
e028d34
Compare
shakurt
force-pushed
the
feat/cn-helper
branch
from
August 15, 2026 15:43
e028d34 to
0fe06d3
Compare
bun compile (tsc --noEmit) failed on CI with exit code 2 — reproduced locally: tsconfig.json extends the gitignored, auto-generated .wxt/tsconfig.json, which only existed via bun install's postinstall hook. That's implicit and apparently not reliable in the CI environment. `bun run build` masked this locally since `wxt build` regenerates .wxt internally, but a bare `tsc` does not. Adding an explicit `wxt prepare` step guarantees the file exists before type-checking runs, regardless of postinstall timing.
Every new component under components/ui/ imports cva from class-variance-authority, but it was never added to package.json — same class of bug as the earlier clsx fix. It only resolved locally from a stray leftover in node_modules that nothing in the actual dependency tree references; a clean install (CI, or anyone cloning fresh) doesn't have it at all, which is what produced the CI type errors (Property 'size'/'selected' does not exist on ...Props) once the wxt-prepare fix got tsc past the earlier config-loading failure. Verified by wiping node_modules and .wxt entirely and reinstalling from scratch: bun run compile and bun run build both pass clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/common/utils/cn.ts:cn()wrapsclsx+ a configuredtailwind-mergeinstance. The config is required, not cosmetic — without it,tailwind-mergedoesn't know about this app's custom classes (bg-glass,rounded-widget,elevation*,z-*, etc.) and gets them wrong:bg-glasswould silently deletebg-contentwherever both are used together, and several custom utilities would lose override fights based on CSS emission order rather than call-site intent. Comments in the file lay out each failure mode..claude/directory (Claude Code session config) in.gitignore.