Skip to content

Remove cross-origin check for simple dialogs - #12794

Merged
annevk merged 1 commit into
mainfrom
noamr/undo-xo-alert
Aug 18, 2026
Merged

Remove cross-origin check for simple dialogs#12794
annevk merged 1 commit into
mainfrom
noamr/undo-xo-alert

Conversation

@noamr

@noamr noamr commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

This behavior was never shipped, due to compat issues.

This reverts #5407 and #6297.
(effective revert of 5f626a1 and 7c8fb86, without removing contributor acknowledgement).

Corresponding tests: web-platform-tests/wpt#62019

(See WHATWG Working Mode: Changes for more details.)


/iframe-embed-object.html ( diff )
/timers-and-user-prompts.html ( diff )

This behavior was never shipped, due to compat issues.
@noamr
noamr requested a review from annevk August 18, 2026 10:27
@annevk

annevk commented Aug 18, 2026

Copy link
Copy Markdown
Member

The commit message should mention the specific commits this is reverting.

And web-platform-tests/wpt#27435 needs to be changed somehow too. Not sure if there are more tests.

@noamr

noamr commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

The commit message should mention the specific commits this is reverting.

And web-platform-tests/wpt#27435 needs to be changed somehow too. Not sure if there are more tests.

Done. I haven't used the template checkboxes here - would that be necessary/better?

@annevk annevk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have reminded you to look for the tests. Apart from that I don't think it's needed for a case where we know nobody plans on shipping it anymore.

@annevk
annevk merged commit 40814eb into main Aug 18, 2026
2 checks passed
@annevk
annevk deleted the noamr/undo-xo-alert branch August 18, 2026 12:44
annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 18, 2026
These tests cover a feature that was never shipped.

See whatwg/html#12794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants