Skip to content

RO-Crate log parser generates wfchef-friendly task names/IDs #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henricasanova merged 4 commits into from
Jul 21, 2026
Merged

RO-Crate log parser generates wfchef-friendly task names/IDs #165

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6ffc8e
Modified the RO-Crate log parser so that it generates wfchef-friendly
henricasanova Jul 21, 2026
06f6e74
Modified the RO-Crate log parser so that it generates wfchef-friendly
henricasanova Jul 21, 2026
3e3bfb2
In RO-Crate log parser, make it that all generated tasks have the same
henricasanova Jul 21, 2026
734937d
Comments++
henricasanova Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions wfcommons/wfinstances/logs/ro_crate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ def _create_tasks(self, create_actions, main_workflow_id):
# Object to track task's "instrument" for further dependencies
instruments = {}

task_idx = 1
for create_action in create_actions:
# Handle overall workflow create_action then skip
if create_action["name"] == f"Run of workflow/{main_workflow_id}":
Expand Down Expand Up @@ -202,9 +203,14 @@ def _create_tasks(self, create_actions, main_workflow_id):
if not start_time or not end_time:
start_time, end_time = self.task_runtimes.get(create_action['name'], (None, None))

task_id = self._sanitize_task_id(create_action['name'] + "_" + create_action['@id'])
# task_id = self._sanitize_task_id(create_action['name'] + "_" + create_action['@id'])
# Using this name/id scheme below is WfChef-friendly
task_name = self._sanitize_task_id(create_action['name'] + f"_ID{task_idx:07d}")
task_id = task_name
task_idx += task_idx

task = Task(name=create_action['name'],
task = Task(#name=create_action['name'],
name=task_name,
# task_id=create_action['name'],
task_id=task_id,
task_type=TaskType.COMPUTE,
Expand Down
Loading