Skip to content

refactor(online_skills): partial text search for Q param - #468

Merged
suifri merged 1 commit into
mainfrom
refactor/online-skills-partial-q-search
Aug 14, 2026
Merged

refactor(online_skills): partial text search for Q param#468
suifri merged 1 commit into
mainfrom
refactor/online-skills-partial-q-search

Conversation

@suifri

@suifri suifri commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved online skills search results by matching entries that end with the entered text.
    • Empty search queries continue to work as expected.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bae9038d-3461-4049-837d-e79ec403e850

📥 Commits

Reviewing files that changed from the base of the PR and between ba78313 and 9b4ffbe.

📒 Files selected for processing (1)
  • store/sqlstore/online_skills.go

📝 Walkthrough

Walkthrough

Search now prepends % to non-empty queries before applying the SQL ILIKE filter. The prepared query value is reused in the SQL arguments.

Changes

Online skills search

Layer / File(s) Summary
Prepare the SQL search query
store/sqlstore/online_skills.go
Search prepends % to non-empty queries and uses the prepared value for the SQL argument Q.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/online-skills-partial-q-search

Comment @coderabbitai help to get the list of available commands.

@suifri
suifri merged commit f2a5f11 into main Aug 14, 2026
9 of 11 checks passed
@suifri
suifri deleted the refactor/online-skills-partial-q-search branch August 14, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant