Skip to content

WTEL-8487: Restrict has_file filter to call recordings in calls history #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlad-marusyk-wt merged 2 commits into from
Aug 13, 2026
Merged

WTEL-8487: Restrict has_file filter to call recordings in calls history #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f39d49
WTEL-8487: Restrict has_file filter to call recordings in calls history
Jul 30, 2026
211211c
refactor has_file filter into shared helper
Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions store/sqlstore/call_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,17 @@ where c.id = :Id::uuid and c.domain_id = :Domain`, map[string]any{
return inst, nil
}

func hasFileFilterSQL(alias string) string {
recordingExists := fmt.Sprintf(`exists(select 1 from storage.files f
where f.domain_id = :Domain::int8
and not f.removed is true
and (f.uuid = %[1]s.id::text or (%[1]s.parent_id notnull and f.uuid = %[1]s.parent_id::text))
and (f.channel isnull or f.channel = 'call')
and (f.mime_type ilike 'audio/%%' or f.mime_type ilike 'video/%%'))`, alias)

return fmt.Sprintf(`and (:HasFile::bool isnull or (case :HasFile::bool when true then %[1]s else not %[1]s end))`, recordingExists)
}

func (s SqlCallStore) GetHistory(ctx context.Context, domainId int64, search *model.SearchHistoryCall, filterOptions ...sqloptions.HistoryCallSQLFilterOption) ([]*model.HistoryCall, model.AppError) {
whereQuery := `
domain_id = :Domain::int8
Expand Down Expand Up @@ -397,7 +408,7 @@ func (s SqlCallStore) GetHistory(ctx context.Context, domainId int64, search *mo
and ( (:SkipParent::bool isnull or not :SkipParent::bool is true ) or parent_id isnull)
and ( (:Timeline::bool isnull or (:Timeline::bool and :DependencyIds::uuid[] notnull and parent_id notnull and ((transfer_from notnull and user_id notnull) or blind_transfer notnull or parent_id != (:DependencyIds::uuid[])[1]))))
and (:ParentId::uuid isnull or parent_id = :ParentId::uuid )
and (:HasFile::bool isnull or (case :HasFile::bool when true then files notnull else files isnull end))
` + hasFileFilterSQL("t") + `
and (:CauseArr::varchar[] isnull or cause = any(:CauseArr) )
and ( (:AnsweredFrom::timestamptz isnull or :AnsweredTo::timestamptz isnull) or answered_at between :AnsweredFrom and :AnsweredTo )
and ( (:DurationFrom::int8 isnull or :DurationFrom::int8 = 0 or duration >= :DurationFrom ))
Expand Down Expand Up @@ -619,7 +630,7 @@ func (s SqlCallStore) GetHistoryByGroups(ctx context.Context, domainId, userSupe
and ( (:SkipParent::bool isnull or not :SkipParent::bool is true ) or parent_id isnull)
and (:ParentId::uuid isnull or parent_id = :ParentId::uuid )
and ( (:Timeline::bool isnull or (:Timeline::bool and :DependencyIds::uuid[] notnull and parent_id notnull and ((transfer_from notnull and user_id notnull) or blind_transfer notnull or parent_id != (:DependencyIds::uuid[])[1]))))
and (:HasFile::bool isnull or (case :HasFile::bool when true then files notnull else files isnull end))
` + hasFileFilterSQL("t") + `
and (:CauseArr::varchar[] isnull or cause = any(:CauseArr) )
and ( (:AnsweredFrom::timestamptz isnull or :AnsweredTo::timestamptz isnull) or answered_at between :AnsweredFrom and :AnsweredTo )
and ( (:DurationFrom::int8 isnull or :DurationFrom::int8 = 0 or duration >= :DurationFrom ))
Expand Down Expand Up @@ -1093,7 +1104,7 @@ func (s SqlCallStore) Aggregate(ctx context.Context, domainId int64, aggs *model
and (:Tags::varchar[] isnull or (h.tags && :Tags))
and (:AgentDescription::varchar isnull or (attempt_id notnull and exists(select 1 from call_center.cc_member_attempt_history cma where cma.id = attempt_id and cma.description ilike :AgentDescription::varchar)))
and (:AmdResult::varchar[] isnull or h.amd_result = any(:AmdResult))
and (:HasFile::bool isnull or (case :HasFile::bool when true then exists(select 1 from storage.files ft where ft.uuid = h.id::text ) else not exists(select 1 from storage.files ft where ft.uuid = h.id::text ) end))
` + hasFileFilterSQL("h") + `
and ((:HasTranscript::bool isnull and :Fts::varchar isnull) or (
case :HasTranscript::bool when false
then not exists(select 1 from storage.file_transcript ft where ft.uuid = h.id::text )
Expand Down
Loading