feat(workspace): auto-detect softphone companion instead of config flag [WTEL-10073] - #1481
Open
dlohvinov wants to merge 1 commit into
Open
feat(workspace): auto-detect softphone companion instead of config flag [WTEL-10073]#1481dlohvinov wants to merge 1 commit into
dlohvinov wants to merge 1 commit into
Conversation
…ag [WTEL-10073](https://webitel.atlassian.net/browse/WTEL-10073) The external-softphone decision is now a loopback probe at client creation: a running utility answers in milliseconds and the browser switches to control-only mode (the probe socket is adopted by the manager, no reconnect flap); connection refused is instant and the web phone is used as before. Re-evaluated per client generation, so a reload picks up a started or quit utility. CLI.externalSoftphone.enabled becomes a tri-state override: absent = auto (new default), true = forced external, false = never probe. Call-store gates (mic bypass, audio-only) now read the runtime mode via isExternalPhoneActive() instead of config; attach() refuses to displace a foreign (webrtc) phone across generations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The external-softphone mode is now chosen by probing
ws://127.0.0.1:<port>at every client creation instead of requiring a config flag:CLI.externalSoftphone.enabledbecomes a tri-state override: absent = auto (new default inpublic/config.json),true= forced external,false= never probe.Implementation notes:
isExternalPhoneActive()— in auto mode config alone can't answerattach()refuses to displace a foreign (webrtc) phone across client generations; the manager is stopped when a generation picks the web phoneJira: WTEL-10073
Test plan
enabled: falsein config → never probes;enabled: true→ external even before utility starts🤖 Generated with Claude Code