feat: add typescript types - #972
Open
43081j wants to merge 1 commit into
Open
Conversation
marco-c
reviewed
Aug 3, 2026
| @@ -0,0 +1,33 @@ | |||
| declare module 'http_ece' { | |||
Contributor
Author
There was a problem hiding this comment.
its in the web-push-libs org so presumably we can land a PR there. i can open one when i get chance 👍
it doesn't need to block this for now though IMO
Member
There was a problem hiding this comment.
I wouldn't block on the asn1 one, but maybe on this one yes, so we don't need to do another PR to remove them once it's done in http_ece directly. WDYT?
Contributor
Author
There was a problem hiding this comment.
Sure I can try find time to look 👍
marco-c
reviewed
Aug 3, 2026
| @@ -0,0 +1,57 @@ | |||
| declare module 'asn1.js' { | |||
Contributor
Author
There was a problem hiding this comment.
it hasn't changed in many years so i'm not very confident we will manage to add them. i can open an issue though
Adds the correct JSDoc so we can use typescript to generate `d.ts` from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the correct JSDoc so we can use typescript to generate
d.tsfrom it.@marco-c this is more a nice-to-have. we have good enough JSDoc to generate the types so it might be nice to do so and publish them.
if you don't think we should, though, let me know.