fix: pass vectorize_collection_name in multi2vec factories - #2138
Open
mayuriphad wants to merge 1 commit into
Open
fix: pass vectorize_collection_name in multi2vec factories#2138mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree with the CLA |
Author
|
Hi maintainers — just checking in on this PR since it hasn't had a maintainer review yet. Happy to make any changes needed; let me know if anything's unclear or if I should split/rework it. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2106
What was the issue?
All
multi2vec_*factories acceptedvectorize_collection_name: bool = Truein their signatures, but the value was not mapped tovectorizeClassNamein_Multi2VecBaseor forwarded frommulti2vec_clip,multi2vec_bind,multi2vec_cohere,multi2vec_voyageai,multi2vec_nvidia,multi2vec_palm,multi2vec_google, andmulti2vec_jinaai.Fix
vectorizeClassName: bool = Trueto_Multi2VecBaseso serialization correctly includesvectorizeClassName.vectorizeClassName=vectorize_collection_namein allmulti2vec_*factory methods acrossconfig_vectorizers.py,config_named_vectors.py, andconfig_vectors.py.test/collection/test_vectorizer.pyverifying serialization for bothTrueandFalsevalues.