feat: add optional location parameter to text2vec-google vectorizer - #447
Merged
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
g-despot
force-pushed
the
feat/text2vec-google-location
branch
2 times, most recently
from
August 14, 2026 09:39
0f68463 to
584dab3
Compare
bevzzz
reviewed
Aug 17, 2026
Note that `location` must match `apiEndpoint`: the endpoint defaults to `us-central1-aiplatform.googleapis.com`, so a lone `location` points the request path at one region and the host at another. Drop the dedicated `location` serialization test: the "all values" case already covers `location` when set, and the "defaults" case pins that there is no client-side default when it is unset.
g-despot
force-pushed
the
feat/text2vec-google-location
branch
from
August 18, 2026 06:49
584dab3 to
547904e
Compare
bevzzz
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
locationparameter (Google Vertex AI region) to thetext2vec-googlevectorizer config. When unset it is omitted from the module config, so the server applies its default.Closes #442