Skip to content

dx: remove obsolete docker compose version key - #116

Open
joshua-seeed wants to merge 1 commit into
masterfrom
joshua/nightly-20260721-docker-compose-v2-warning
Open

dx: remove obsolete docker compose version key#116
joshua-seeed wants to merge 1 commit into
masterfrom
joshua/nightly-20260721-docker-compose-v2-warning

Conversation

@joshua-seeed

Copy link
Copy Markdown
Collaborator

Description

Remove the deprecated top-level version key from infra/docker-compose.yml.

Why it matters:

  • Docker Compose v2 now ignores that field and prints an avoidable warning on every local sandbox bring-up.
  • This keeps the documented local sandbox bootstrap path quieter and less confusing for maintainers and agents.

Pull Request Checklist

  • No Secrets: I have checked that no secrets, API keys, private tokens, or credentials are included in this PR.
  • No Prompt-Injection: This PR does not contain instructions designed to override or redirect AI reviewers, operators, or workflows.
  • Supported vs Planned: I did not present planned or unimplemented capabilities as already shipped.
  • Verification Run: I ran the relevant local verification for this change.
  • Docs Updated: I updated the documentation (such as docs/api/native-api.md, docs/agent-discovery.md, agent-skill-kit/, or public discovery assets) if public or agent-facing behavior changed.
  • Discovery Parity: If this PR changes llms.txt, llms-full.txt, .well-known/*.json, or other static discovery files, I ran pnpm verify:discovery:strict.
  • Database Migrations: I have included migration SQL files if database schemas were modified.

Verification & Test Evidence

Docs-only / infra-config verification run for this change:

docker compose -f infra/docker-compose.yml up -d
# Result before change: emitted "the attribute `version` is obsolete"
# Result after change: container started/running without the obsolete-version warning

Additional nightly repo-health evidence gathered in the same session:

pnpm verify:discovery:strict
pnpm verify:vitest-guard
pnpm audit --prod --audit-level=high
pnpm db:reset
pnpm db:seed
NODE_ENV=test pnpm selftest:mock

Observed results:

  • pnpm verify:discovery:strict passed (normalized parity/content types; raw-byte LF/CRLF warning only)
  • pnpm verify:vitest-guard passed
  • pnpm audit --prod --audit-level=high returned No known vulnerabilities found
  • pnpm db:reset passed
  • pnpm db:seed passed
  • NODE_ENV=test pnpm selftest:mock still fails on current master for the already-known self-test path and is not caused by this compose-file cleanup

Security / Agent-Safety Notes

  • No runtime money-path code changed.
  • No dependency versions changed.
  • No discovery assets changed.
  • This is local developer/sandbox DX cleanup only.

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
commerce-backend Ready Ready Preview, Comment Jul 21, 2026 4:19am
commercebackend Ready Ready Preview, Comment Jul 21, 2026 4:19am

Request Review

@joshua-seeed
joshua-seeed requested a review from rsaer July 21, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant