feat: expose native canvas present modes - #453
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
presentModefield toGPUCanvasConfigurationfifo,fifo-relaxed,immediate, andmailboxto Dawn's native surface modesSurfaceRegistryfrom overwriting the caller's selectionThis addresses the present-mode portion of #444. It intentionally does not add DisplayLink/Choreographer ownership or a refresh-rate scheduler, matching the maintainer's scope guidance in the issue.
Unsupported modes remain subject to Dawn's existing surface configuration validation.
Verification
yarn workspace react-native-webgpu tscyarn workspace react-native-webgpu test:node CanvasConfiguration.spec.ts(3 tests passed)yarn workspace react-native-webgpu buildyarn workspace docs tscyarn workspace docs build:docsclang++ -std=c++20 -fsyntax-only ... GPUCanvasContext.cppcpplinton all changed C++ filesThe full local Node-WebGPU suite also ran; all relevant tests passed, with one unrelated existing Node backend failure in
GPU.spec.tswherelimits.maxBindGroupsserializes asundefined.