Fix boats not receiving input in 2021 - #935
Closed
magenta404 wants to merge 2 commits into
Closed
Conversation
We did not respect the "update mode" setting but it worked before 2021.2 for some reason. Input in "update" looks to be the default so this will cover us for now.
huwb
reviewed
Oct 27, 2021
huwb
left a comment
huwb
left a comment
Contributor
There was a problem hiding this comment.
I'm surprised that it breaks. I would have thought that reading it in the wrong update would put you at risk of getting old input values from last frame, in the wrist case. But this implies you get no input at all? That seems wrong..
Contributor
|
Have others had to add two update functions as well, are you aware? These add significant runtime cost so it seems a bit crazy to me if everyone is going to have to do this. |
Collaborator
Author
|
True... I checked the forum and looks like the next version of the input package fixes it. It's not available yet from what I could see. Will close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following setting is also in 2020, but for some reason input still worked even though we were reading input in FixedUpdate and the default is DynamicUpdate.
This PR respects this setting by reading input in either Update or FixedUpdate depending on chosen mode. This is pretty rough but will be implemented nicer with #486.