Baro Bugfixes - #71
Open
AnSq wants to merge 2 commits into
Open
Conversation
* "leaving soon" notification works again * now becomes locked when becoming unavailable while not checked * now becomes unlocked when becoming available without needing a refresh * v5.3.1
Fixed tasks with cycle schedules that observe DST (only Baro) not showing the correct current offering when they reset when DST is active. * renamed "cycle number" to "reset count" because it doesn't have anything to do with the cycle schedule feature and that's confusing * all daily and weekly tasks are now prepped with a period, not just alternate ref ones * new `fixTimeTravel` function to aid with debugging * removed some error checking for stuff that's checked in tests * added test to validate cycle refs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure:
Here's the bugfixes factored out of #69 as discussed. You can merge either this or #69 first, and I'll fix the resulting merge conflicts with the other one.
Bug Fixes
Code Stuff
period, not just alternaterefones.fixTimeTravelfunction to aid with debugging.refs.