msteams: maxRetryWait param to control waiting after 429 responses - #235
Open
benbroadaway wants to merge 3 commits into
Open
msteams: maxRetryWait param to control waiting after 429 responses#235benbroadaway wants to merge 3 commits into
benbroadaway wants to merge 3 commits into
Conversation
ibodrov
previously approved these changes
Apr 30, 2026
| throw new IllegalStateException("Too many requests. Cannot wait long enough to retry."); | ||
| } | ||
|
|
||
| log.warn("exec [webhookUrl: '{}', params: '{}'] -> too many requests, retry after {} sec", webhookUrl, params, retryAfter); |
Collaborator
There was a problem hiding this comment.
I think millisecond values as being used as seconds here: retry after 30000 sec
Also, V1 says "sec", V2 uses "ms".
Collaborator
Author
There was a problem hiding this comment.
Astute observation. I offer a...timely...resolution 🤕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MS Graph API may return relatively huge durations to wait after a 429 response (e.g.
600seconds) which may be far longer than reasonable for a process to sleep before a retry. If the response-givenRetry-Afteris higher than themaxRetryWaitparam, then the task call ends with an exception (or silently ends ifignoreErrorsistrue).maxRetryWaitto control when to give up retrying instead of waiting for a rate limit reset30000ms (30s)