added delete fucntionality - #234
Conversation
|
|
| String forceRefresh(); | ||
|
|
||
| String appProject(); |
There was a problem hiding this comment.
These should be @Nullable (or have a default value).
| if (!deleteParm.forceRefresh().isEmpty() && !deleteParm.forceRefresh().isBlank()) { | ||
| builder.header("forceRefresh", deleteParm.forceRefresh()); | ||
| } | ||
| if (!deleteParm.appProject().isEmpty() && !deleteParm.appProject().isBlank()) { | ||
| builder.header("appProject", deleteParm.appProject()); | ||
| } |
There was a problem hiding this comment.
Remove isEmpty() check. Checking isBlank() covers both cases.
| if (!deleteParm.forceRefresh().isEmpty() && !deleteParm.forceRefresh().isBlank()) { | ||
| builder.header("forceRefresh", deleteParm.forceRefresh()); | ||
| } | ||
| if (!deleteParm.appProject().isEmpty() && !deleteParm.appProject().isBlank()) { |
There was a problem hiding this comment.
Need a null check for both forceRefresh() and appProject().
| - type: string | ||
| description: whether to force a cache refresh on repo's connection state | ||
| name: forceRefresh | ||
| in: query | ||
| required: true | ||
| - type: string | ||
| description: App project for query | ||
| name: appProject | ||
| in: query |
There was a problem hiding this comment.
This doesn't seem like the correct location for manually adding these params to the spec. These params aren't in an up-to-date spec that I can find.
| String forceRefresh(); | ||
|
|
||
| String appProject(); |
There was a problem hiding this comment.
I'm not sure these params make sense here. They're not part of the api spec, and why would something need to be refreshed when the application is deleted?
4 participants
No description provided.