git: remove egit dependency from GitHub task, refactor a bit - #204
Draft
ibodrov wants to merge 1 commit into
Draft
git: remove egit dependency from GitHub task, refactor a bit#204ibodrov wants to merge 1 commit into
ibodrov wants to merge 1 commit into
Conversation
Replace EGit's client with the standard HttpClient. Tidy up the code a bit.
ibodrov
marked this pull request as draft
July 7, 2025 20:23
benbroadaway
reviewed
Jul 9, 2025
Comment on lines
+951
to
+955
| HttpRequest.Builder requestBuilder = HttpRequest.newBuilder() | ||
| .uri(URI.create(url)) | ||
| .timeout(Duration.ofSeconds(30)) | ||
| .header("Accept", "application/vnd.github.v3+json") | ||
| .header("Authorization", "token " + token); |
Collaborator
There was a problem hiding this comment.
I think setting a User-Agent header is a nice thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.eclipse.egit.github.core looks dead.
Replace EGit's client with the standard HttpClient. Tidy up the code a bit.