Skip to content

fix: detect punctuated IPv4 URLs - #68

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/detect-punctuated-ipv4-urls
Open

fix: detect punctuated IPv4 URLs#68
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/detect-punctuated-ipv4-urls

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • detect IPv4 URL literals when common punctuation, rather than whitespace, delimits them
  • avoid treating embedded addresses, IPv4 email domain literals, or malformed port suffixes as URLs
  • add focused regression coverage for accepted and rejected boundaries

Verification

  • dotnet build --consoleLoggerParameters:ErrorsOnly — passed: 0 errors (2 warnings)
  • dotnet test Morpheus.Tests/Morpheus.Tests.csproj --filter FullyQualifiedName~UtilsTests --consoleLoggerParameters:ErrorsOnly — passed: 40/40
  • dotnet test --no-build --filter 'FullyQualifiedName!~MiscModuleTests.NormalizeTimeUntilEventName_NormalizesCase' --consoleLoggerParameters:ErrorsOnly — passed: 314/314
  • DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 dotnet test --no-build --consoleLoggerParameters:ErrorsOnly — 314 passed, 2 failed: the existing MiscModuleTests.NormalizeTimeUntilEventName_NormalizesCase cases require tr-TR, which is unavailable in this invariant-globalization runner
  • git diff --check upstream/develop...HEAD — passed

Risk

  • Low — the change is isolated to IPv4 boundary detection and includes positive and false-positive regression cases.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant