Document WorldMapViewModel - #208
Conversation
f343899 to
f72a86f
Compare
| } | ||
|
|
||
| #[repr(C)] | ||
| pub struct WorldMapViewModelUnk50 { |
There was a problem hiding this comment.
Consider using UnknownStruct for structs where we don't know the names of the struct or any fields.
There was a problem hiding this comment.
Why use such a generic name if this type grants it an easier name to communicate with?
There was a problem hiding this comment.
I mean the UnknownStruct that's defined in the shared package. So in this case, instead of defining this struct, you'd just write unk50: UnknownStruct<0x20>, and then fill it out later once you know anything about the semantics.
There was a problem hiding this comment.
Am not sure how sensible this is in this situation since we do know the layout for the most part (obtained by inspecting the constructor)
There was a problem hiding this comment.
Although I do see a point in not exposing these types, hmm give me a few to think on this
There was a problem hiding this comment.
My feeling is that if we have no information on the actual meaning of the struct or any of its fields, the layout isn't really useful at all. You'd need to see it in use to make any sense of it, which effectively means you'd need Ghidra access anyway, so keeping that layout data in Ghidra isn't causing any harm.
Co-authored-by: Natalie Weizenbaum <nex342@gmail.com>
Co-authored-by: Natalie Weizenbaum <nex342@gmail.com>
Co-authored-by: Natalie Weizenbaum <nex342@gmail.com>
Co-authored-by: Natalie Weizenbaum <nex342@gmail.com>
2 participants
No description provided.