change scope of resource override

[dacron]

Pull Request (PR) description

Pull request fixes a resource override scoping issue in splunk::forwarder::install.

When being installed on a machine with no existing installation of the net-tools package, the generic override of::

Package  {
  source         => $splunk::forwarder::package_provider ? {
    'chocolatey' => undef,
    default      => $splunk::forwarder::manage_package_source ? {
      true  => pick($_staged_package, $_package_source),
      false => $_package_source,
    }
  },
}

Results in a net-tools resource of:

package { 'net-tools':
  ensure => 'present',
  source => $splunk::forwarder::manage_package_source,
  before => Package[splunkforwarder],
}

This Pull Request (PR) fixes the following issues

n/a.

[dacron]

@ghoneycutt - this looks like a Solaris only failure?

[vox-pupuli-tasks]

Dear @dacron, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[vox-pupuli-tasks]

Dear @dacron, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks