Introduce pkg/sdk go.mod and VPCNetworkConfiguration function helpers - #68
Open
ihgann wants to merge 5 commits into
Open
Introduce pkg/sdk go.mod and VPCNetworkConfiguration function helpers#68ihgann wants to merge 5 commits into
ihgann wants to merge 5 commits into
Conversation
This change introduces a new go.mod for pkg/sdk to keep it isolated from the root go.mod and introduces VPCNetworkConfiguration function helpers related to NamespaceNetworkConfiguration in pkg/sdk.
yangna0420
approved these changes
Aug 20, 2026
yangna0420
left a comment
yangna0420
left a comment
There was a problem hiding this comment.
Thanks， I need replied on this changes on my VPC get
yangna0420
reviewed
Aug 20, 2026
This change introduces a fix to hack/client-gen.sh which was mistakenly broken upon a controller-runtime update in hack/tools/go.mod. The two issues include: 1. --input-base $PKG/api --input /$VERSION used empty-group syntax, which newer client-gen (v0.35.0) maps to literal core path segment → tried importing nonexistent api/core/v1alpha1. Fixed to --input-base $PKG --input api/$VERSION so the real path api/v1alpha1 resolves. 2. --clientset-name flag was never passed (defaults to internalclientset, but output paths assumed clientset), and output-dir/output-pkg redundantly appended the clientset name on top of what client-gen already appends, causing double-nested clientset/clientset. Fixed by adding --clientset-name $CLIENTSET_NAME and pointing output-dir/output-pkg at the parent dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new go.mod for pkg/sdk to keep it isolated from the root go.mod and introduces VPCNetworkConfiguration function helpers related to NamespaceNetworkConfiguration in pkg/sdk.
Testing Done:
make lint test