successful run shell and agent_loop app on esp32c6 - #453
Conversation
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32239146165. |
|
❌ Job failed. Failed jobs: check_format (failure), check_license (failure), build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/32239146165. |
00a386d to
3f205b1
Compare
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32248187822. |
|
❌ Job failed. Failed jobs: check_format (failure), check_license (failure), see https://github.com/vivoblueos/kernel/actions/runs/32248187822. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32249507402. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/32249507402. |
| //pub const DEFAULT_STACK_SIZE: usize = 32 << 10; | ||
| #[cfg(all(not(debug_assertions), target_pointer_width = "32"))] | ||
| pub const DEFAULT_STACK_SIZE: usize = 4 << 10; | ||
| //pub const DEFAULT_STACK_SIZE: usize = 32 << 10; |
There was a problem hiding this comment.
Plz del unnecessary comment
| mod idle; | ||
| pub use idle::{ | ||
| current_idle_thread, current_idle_thread_ref, get_idle_thread, get_idle_thread_ref, | ||
| set_idle_hook, |
There was a problem hiding this comment.
Plz del unused import mod
| } | ||
|
|
||
| #[cfg(soc_esp32c3)] | ||
| // esp32_wlan registration gating mirrors net/link/mod.rs: must be any(c3,c6), |
There was a problem hiding this comment.
Del unecessary comment
| // (OSI callback table + scan/connect/tx-rx), shared by C3/C6 from the same code | ||
| // skeleton; only the low-level wifi-sys crate and a few register/peripheral base | ||
| // addresses switch by cfg (see esp32_wlan/mod.rs, api.rs). | ||
| // Must use any(c3,c6): if only soc_esp32c3 is written, then C6 (soc_esp32c6) fails |
There was a problem hiding this comment.
OK, thank you. I will update it and also review for any similar issues.
3f205b1 to
dc2a3fc
Compare
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32374615472. |
|
❌ Job failed. Failed jobs: setup (failure). Skipped jobs: check_format (skipped), check_license (skipped), build_host (skipped), build_and_check_boards (skipped), see https://github.com/vivoblueos/kernel/actions/runs/32374615472. |
dc2a3fc to
8ba29ca
Compare
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32438697356. |
|
❌ Job failed. Failed jobs: setup (failure). Skipped jobs: check_format (skipped), check_license (skipped), build_host (skipped), build_and_check_boards (skipped), see https://github.com/vivoblueos/kernel/actions/runs/32438697356. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32439126804. |
|
❌ Job failed. Failed jobs: check_format (failure), see https://github.com/vivoblueos/kernel/actions/runs/32439126804. |
8ba29ca to
9904b40
Compare
9904b40 to
b4a0762
Compare
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32721071812. |
|
❌ Job failed. Failed jobs: setup (failure). Skipped jobs: check_format (skipped), check_license (skipped), build_host (skipped), build_and_check_boards (skipped), see https://github.com/vivoblueos/kernel/actions/runs/32721071812. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32721604143. |
|
❌ Job failed. Failed jobs: check_format (failure), build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/32721604143. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32722685222. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/32722685222. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32818840795. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32820687186. |
|
❌ Job failed. Failed jobs: check_format (failure), see https://github.com/vivoblueos/kernel/actions/runs/32818840795. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/32820687186. |
|
build_prs #453 vivoblueos/build#74 vivoblueos/external#34 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32964798534. |
|
build_prs #453 vivoblueos/build#74 vivoblueos/external#34 |
|
❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/32964798534. |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/32965635175. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/32965635175. |
|
build_prs #453 vivoblueos/build#74 vivoblueos/external#34 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/33599731619. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/33599731619. |
| fn clear_line(&self, pos: u64, is_blocking: bool) -> Result<(), ErrorKind> { | ||
| self.dev.send_bytes(b"\r", !is_blocking)?; | ||
| self.dev.send_bytes(b"\x1b[2K", !is_blocking)?; | ||
| fn clear_line(&self, pos: u64, is_nonblocking: bool) -> Result<(), ErrorKind> { |
There was a problem hiding this comment.
clear_line's call sites at n_tty.rs:272 and :278 still pass the literal false, is it right ?
There was a problem hiding this comment.
It's unnecessary to change the semantics.
| // bit0-10: wifibb_22m/40m/44m/80m/40x/80x/40x1/80x1/160x1 + wifimac + wifi_apb | ||
| // bit13-16: fe_80m / fe_160m / fe_cal_160m / fe_apb | ||
| // bit11 (fe_20m) and bit12 (fe_40m) are not in the enable_wifi set range, keep original value. | ||
| const CLK_CONF1_WIFI_FE_MASK: u32 = 0x0001_F7FF; // bit0-10 | bit13-16 |
There was a problem hiding this comment.
0x1F7FF = bits 0-10 + bit 12 + bits 13-16, bits 0-10 | bits 13-16 is 0x1E7FF
successful run shell and agent_loop app on esp32c6