deps: upgrade devframe to 0.7.2#428
Merged
Merged
Conversation
Bumps devframe, @devframes/hub, and the built-in plugin packages (inspect/messages/terminals) from ^0.7.0 to ^0.7.2. devframes/devframe#98 makes cross-base RPC connection-meta inheritance native: the client now annotates the meta it publishes on the shared window with an absolute `baseUrl`, and a same-origin child iframe resolves its inherited `websocket.path` against that base instead of its own mount. This obsoletes the kit-side workaround in `getDevToolsRpcClient` (packages/kit/src/client/connection.ts) that manually rewrote the published meta to an absolute path - simplified to a thin pass-through to devframe's own `getDevframeRpcClient`. Updated the dock-popup connection-meta comment in packages/core to match. This PR was created with the help of an agent.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
devframe,@devframes/hub, and the built-in plugin packages (@devframes/plugin-inspect/plugin-messages/plugin-terminals) from^0.7.0to^0.7.2, and migrates devframes/devframe#98.That upstream PR makes cross-base RPC connection-meta inheritance native to devframe's client: it now annotates the connection meta it publishes on the shared window with an absolute
baseUrl, and a same-origin child iframe (e.g. Terminals, the Devframe Inspector, mounted at their own/__devframes-plugin-*/base) resolves its inheritedwebsocket.pathagainst that base instead of its own mount.This obsoletes the kit-side workaround this repo carried in
getDevToolsRpcClient(packages/kit/src/client/connection.ts), added in #414 to manually rewrite the published connection meta to an absolute path before devframe supported this natively. That rewriting logic is removed;getDevToolsRpcClientis now a thin pass-through to devframe's owngetDevframeRpcClient, kept only for naming symmetry with the kit's otherDevTools*-prefixed primitives — its public signature is unchanged. Also updated a stale comment inpackages/core's dock-popup connection-meta handling to reflect that devframe now publishes the annotated meta itself.The kit's existing
mountConnectionMetafetch-path fix (serving per-base__connection.jsonwith a rebasedwebsocket.path) is unrelated to this upstream change and is unaffected.Linked Issues
Migrates devframes/devframe#98
Additional context
pnpm lint,pnpm typecheck,pnpm build, andpnpm testall pass, aside from one pre-existing, unrelated test failure (resolves optional integrations from the configured project directoryinpackages/core/src/node/plugins/__tests__/index.test.ts) that reproduces identically onmainbefore this change.getDevToolsRpcClienttsnapi runtime snapshot to match the simplified (non-async) signature; the declared type signature is unchanged.This PR was created with the help of an agent.