Skip to content

deps: upgrade devframe to 0.7.2#428

Merged
antfu merged 1 commit into
mainfrom
deps/devframe-0.7.2
Jul 16, 2026
Merged

deps: upgrade devframe to 0.7.2#428
antfu merged 1 commit into
mainfrom
deps/devframe-0.7.2

Conversation

@antfubot

Copy link
Copy Markdown
Collaborator

Description

Bumps devframe, @devframes/hub, and the built-in plugin packages (@devframes/plugin-inspect/plugin-messages/plugin-terminals) from ^0.7.0 to ^0.7.2, and migrates devframes/devframe#98.

That upstream PR makes cross-base RPC connection-meta inheritance native to devframe's client: it now annotates the connection meta it publishes on the shared window with an absolute baseUrl, and a same-origin child iframe (e.g. Terminals, the Devframe Inspector, mounted at their own /__devframes-plugin-*/ base) resolves its inherited websocket.path against that base instead of its own mount.

This obsoletes the kit-side workaround this repo carried in getDevToolsRpcClient (packages/kit/src/client/connection.ts), added in #414 to manually rewrite the published connection meta to an absolute path before devframe supported this natively. That rewriting logic is removed; getDevToolsRpcClient is now a thin pass-through to devframe's own getDevframeRpcClient, kept only for naming symmetry with the kit's other DevTools*-prefixed primitives — its public signature is unchanged. Also updated a stale comment in packages/core's dock-popup connection-meta handling to reflect that devframe now publishes the annotated meta itself.

The kit's existing mountConnectionMeta fetch-path fix (serving per-base __connection.json with a rebased websocket.path) is unrelated to this upstream change and is unaffected.

Linked Issues

Migrates devframes/devframe#98

Additional context

  • pnpm lint, pnpm typecheck, pnpm build, and pnpm test all pass, aside from one pre-existing, unrelated test failure (resolves optional integrations from the configured project directory in packages/core/src/node/plugins/__tests__/index.test.ts) that reproduces identically on main before this change.
  • Updated the getDevToolsRpcClient tsnapi runtime snapshot to match the simplified (non-async) signature; the declared type signature is unchanged.

This PR was created with the help of an agent.

Bumps devframe, @devframes/hub, and the built-in plugin packages
(inspect/messages/terminals) from ^0.7.0 to ^0.7.2.

devframes/devframe#98 makes cross-base RPC connection-meta
inheritance native: the client now annotates the meta it publishes
on the shared window with an absolute `baseUrl`, and a same-origin
child iframe resolves its inherited `websocket.path` against that
base instead of its own mount. This obsoletes the kit-side
workaround in `getDevToolsRpcClient` (packages/kit/src/client/connection.ts)
that manually rewrote the published meta to an absolute path -
simplified to a thin pass-through to devframe's own
`getDevframeRpcClient`. Updated the dock-popup connection-meta
comment in packages/core to match.

This PR was created with the help of an agent.
@pkg-pr-new

pkg-pr-new Bot commented Jul 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/vitejs/devtools/@vitejs/devtools@428

@vitejs/devtools-kit

npm i https://pkg.pr.new/vitejs/devtools/@vitejs/devtools-kit@428

@vitejs/devtools-oxc

npm i https://pkg.pr.new/vitejs/devtools/@vitejs/devtools-oxc@428

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/vitejs/devtools/@vitejs/devtools-rolldown@428

@vitejs/devtools-vite

npm i https://pkg.pr.new/vitejs/devtools/@vitejs/devtools-vite@428

@vitejs/devtools-vitest

npm i https://pkg.pr.new/vitejs/devtools/@vitejs/devtools-vitest@428

commit: a750244

@antfu
antfu merged commit a54949a into main Jul 16, 2026
9 of 10 checks passed
@antfu
antfu deleted the deps/devframe-0.7.2 branch July 16, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants