Wrap hackney:close in try/catch to prevent crash when ETS table is gone#3
Open
p424p424 wants to merge 1 commit into
Open
Wrap hackney:close in try/catch to prevent crash when ETS table is gone#3p424p424 wants to merge 1 commit into
p424p424 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the streaming process calls
hackney:close/1during cleanup, hackney's connection-manager ETS table may already have been torn down by another process, causing abad argumentcrash inets:lookup/2.This is a race condition — it happens intermittently, always after the stream has finished and the response has been delivered, so it's cosmetic (exit code is still 0). But it produces a scary-looking CRASH REPORT in the terminal.
The fix wraps the close call in a try/catch, matching the pattern already used throughout hackney itself for similar cleanup operations.
Before
After