✨ Add typed JVM dialog parents - #629
Open
vinceglb wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parentWindowsetting with one canonical typedFileKitDialogParentThis intentionally makes a breaking JVM API change to keep the model simple: callers migrate from
parentWindow = windowtoparent = FileKitDialogParent.awt(window)(or the matching native factory).Requested from the Kotlin Slack discussion to improve integration with Nucleus using the Tao backend.
Validation
./gradlew :filekit-dialogs:jvmTest :filekit-dialogs-compose:jvmTest --no-daemon./gradlew :filekit-dialogs:check :filekit-dialogs-compose:check --no-daemon./gradlew :sample:shared:check :sample:nucleusApp:compileKotlin --no-daemon./gradlew check --no-daemon(572 tasks)Manual verification
Windows runtime verification should confirm that the Nucleus Tao sample passes its borrowed HWND to native dialogs and preserves owner-relative modality/stacking. This macOS host cannot execute that Windows-only smoke test.
The Nucleus packaging task could not run locally because the configured Android Studio JBR does not include
jpackage; compilation is green and hosted CI uses Temurin JDK 21.