Fix selection with small samples and exceptions after destroy - #7939
Merged
Conversation
github-project-automation
Bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
github-project-automation
Bot
moved this from Top priorities
to Done
in HLS.js Release Planning and Backlog
Collaborator
Author
|
Merging #7938 for additional coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix selection with small samples and exceptions after
hls.destroy()is called.Why is this Pull Request needed?
Fixes #7937 and https://elements-demo-vanilla-git-fork-luwes-feat-min-bandwi-4a56fa-mux.vercel.app/min-bandwidth-sample-duration-ms-test.html#noCap=1 cc @luwes
Resolves issues:
Fixes #7937
Related to #3595