Fix multi-level merges in vg gamsort - #5023
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg gamsortno longer crashes with very large GAM files.Description
vg gamsorttries to do up to 2048-way merges if possible. If the GAM file is very large (more than ~1 TiB of uncompressed data / ~200 GiB of compressed data / ~60x coverage of human short reads), there will be more than 2048 temporary files after the initial sort.vg gamsorthas to do intermediate merges with such inputs, but that code path has always been broken. This PR fixes the issue by opening ranges of input files (rather than output files) for the intermediate merges.Fixes #5022.
Also fixes the progress bars in
vg gamsort.