Fix Dozeu X-drop a different way - #5020
Merged
Merged
Conversation
Member
Author
|
I don't want to merge this until I'm sure that @mgawan is happy with that Dozeu commit actually going into the project. If not, we'd want to back it out again. |
|
All is good from our end. Thanks for working on it. I believe I had missed Jordan's more recent commits on his PR. But looks like we both ended up with the same end fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
dozeurespects X-drop definition more strictlyDescription
This takes some fixes that @jeizenga and @mgawan hammered out that fix a bug in traceback in Dozeu, using @mgawan's code.
This goes with vgteam/dozeu#17.
I tried to also merge in vgteam/dozeu#16, but I ended up with a Dozeu commit with, as far as I could tell, no non-comment code changes versus vgteam/dozeu#17 but which made vg fail the
vg test "[xdrop]"tests. So this is taking @mgawan's version as merged into Dozeu. @mgawan said some things I didn't really understand about the changes not actually working on our mainline Dozeu, which differed from what they were built on by what looks to me like a no-op merge commit, so if something goes wrong here we might need to do some serious Git surgery to unravel what's going on.This closes #4997, a competing PR to do the same basic thing