Update LaunchDarkly examples for native Vercel Marketplace integration#1532
Open
mbrakken wants to merge 3 commits into
Open
Update LaunchDarkly examples for native Vercel Marketplace integration#1532mbrakken wants to merge 3 commits into
mbrakken wants to merge 3 commits into
Conversation
Update the LaunchDarkly Flags SDK and edge-middleware examples to use the native LaunchDarkly Marketplace integration. - Bump @flags-sdk/launchdarkly to ^1.0.0 - Rename EDGE_CONFIG to EXPERIMENTATION_CONFIG - Use the Marketplace products deploy param instead of legacy integration-ids - Document enabling the Edge Config sync from the integration resource
mbrakken
requested review from
dominiksipowicz,
goncy,
lfades,
lpalmes and
okbel
as code owners
July 14, 2026 14:58
Contributor
Contributor
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
Andrewjeska
suggested changes
Jul 17, 2026
| deployButton={{ | ||
| customDeployUrl: | ||
| 'https://vercel.com/new/clone?repository-url=https://github.com/vercel/examples/tree/main/edge-middleware/feature-flag-launchdarkly&project-name=feature-flag-launchdarkly&repository-name=feature-flag-launchdarkly&integration-ids=oac_8DFUMlauSkqeQhdGHpL5xbWp&env=NEXT_PUBLIC_LD_CLIENT_SIDE_ID&env=EDGE_CONFIG&edge-config-stores=%7B%22EDGE_CONFIG%22%3A%7B%7D%7D', | ||
| 'https://vercel.com/new/clone?repository-url=https://github.com/vercel/examples/tree/main/edge-middleware/feature-flag-launchdarkly&project-name=feature-flag-launchdarkly&repository-name=feature-flag-launchdarkly&env=NEXT_PUBLIC_LD_CLIENT_SIDE_ID&products=%5B%7B%22integrationSlug%22%3A%22launchdarkly%22%2C%22productSlug%22%3A%22launchdarkly%22%2C%22type%22%3A%22integration%22%2C%22protocol%22%3A%22experimentation%22%7D%5D', |
There was a problem hiding this comment.
You shouldn't need NEXT_PUBLIC_LD_CLIENT_SIDE_ID anymore, we provide this as NEXT_PUBLIC_LAUNCHDARKLY_CLIENT_SIDE_ID
Author
There was a problem hiding this comment.
Oh yeah, I think I even noticed this, but forgot while trying to get access to the account that the projects live in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the LaunchDarkly examples to use the new native LaunchDarkly Vercel Marketplace integration, alongside the upcoming
@flags-sdk/launchdarklyv1.0.0 release.The key change is that the Edge Config connection string is now exposed as
EXPERIMENTATION_CONFIG(renamed fromEDGE_CONFIG), matching the native Marketplace integration and other experimentation adapters (e.g. Statsig).flags-sdk/launchdarkly@flags-sdk/launchdarkly^0.3.2→^1.0.0(v1.0.0 readsEXPERIMENTATION_CONFIGby default).env.example:EDGE_CONFIG→EXPERIMENTATION_CONFIGproductsdeploy param + docs on enabling the Edge Config sync from the integration resourcepnpm-lock.yamledge-middleware/feature-flag-launchdarklypage.tsx: read connection string fromEXPERIMENTATION_CONFIGintegration-ids/edge-config-storesparams with the MarketplaceproductsparamNotes
toolbar/toolbar-launchdarklyis unaffected (usesLAUNCHDARKLY_SDK_KEYdirectly, no Edge Config).