chore: fix go-git CVEs, sweep deps, clean stray binaries - #25
Merged
Conversation
Resolves GO-2026-4910, GO-2026-4909, GO-2026-4473 (idx/pack file handling in go-git) reached via internal/ignore. govulncheck now reports 0 reachable vulnerabilities.
Deletes ~24MB of compiled binaries left in the repo root (redactyl, redactyl_tui, redactyl_test) and root-anchors them in .gitignore so they stop showing up as untracked.
Notable direct bumps: - charmbracelet/bubbles v0.21.0 => v1.0.0 (still on bubbletea v1.3.10) - alecthomas/chroma v2.20.0 => v2.27.0 - google/go-containerregistry v0.20.7 => v0.21.7 - spf13/cobra v1.10.1 => v1.10.2 - olekukonko/tablewriter v1.0.9 => v1.1.4 - klauspost/compress off retracted v1.18.1 => v1.19.0 govulncheck clean, full test suite passes, scan/detection smoke-tested.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency and housekeeping pass. Fixes 3 reachable vulnerabilities in go-git, sweeps dependencies to latest, and removes stray build artifacts from the repo root.
Related Issue
No tracking issue. Vulnerabilities surfaced by
govulncheck ./....Type of Change
Motivation
govulncheckreported 3 vulnerabilities ingo-gitv5.16.2 that our code actually reaches (viainternal/ignore): GO-2026-4910, GO-2026-4909, GO-2026-4473, all in idx/pack file handling. Dependencies were also broadly stale, and roughly 24MB of compiled binaries had been left untracked in the repo root.Changes
go-git/go-gitv5.16.2 to v5.19.1.govulnchecknow reports 0 reachable vulnerabilities.go get -u ./...to latest. Notable direct bumps:charmbracelet/bubblesv0.21.0 to v1.0.0 (stays on bubbletea v1.3.10, not the v2 migration)alecthomas/chromav2.20.0 to v2.27.0google/go-containerregistryv0.20.7 to v0.21.7spf13/cobrav1.10.1 to v1.10.2olekukonko/tablewriterv1.0.9 to v1.1.4klauspost/compressoff retracted v1.18.1 to v1.19.0redactyl,redactyl_tui,redactyl_test) and root-anchor them in.gitignoreso they stop appearing as untracked.Testing
go test ./...)go build ./...,go vet ./..., and the fullgo test ./...suite pass, including the TUI package.govulncheck ./...reports no vulnerabilities. Manually built the binary and ran a scan against a directory with a realistic secret: detection and table rendering both work after the tablewriter and charm upgrades.Checklist
Notes for reviewer
bubblesv0.21 to v1.0 is a major bump. Unit tests and a headless scan pass, but the interactive TUI could not be driven headlessly. A quick manualredactyl scanin a real terminal before merge is worth it.1.0.1(stale ldflags default) while the released tag is v1.0.2.