feat: propagate child-record deletions via tombstones - #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes deletions of child records (links, tags, annotations, summaries) propagate across machines via tombstones, closing the additive-merge gap flagged during the per-repo sync review.
tombstonestable. User-facing child deletes (unlink, tag/annotation/summary removal) record a tombstone. Session-cascade deletes (lore delete, prune) do NOT tombstone; they use inline SQL, so deleting your local copy of a session never removes it from the shared store.meta/tombstonesblob, union-merged across machines. The blob is rewritten only when the set changes, preserving content-addressed dedup.Tests: deletion propagates and is not resurrected; a concurrent add survives a remote deletion; a stale remote blob containing a tombstoned child is suppressed; session-cascade delete records no tombstones; GC; both stores. Full suite green, clippy
-D warningsclean.