Skip to content

fix(tests): fix saved views auth rejection tests in test_saved_views.py #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trivikramkalagi91-commits wants to merge 2 commits into from
Closed

fix(tests): fix saved views auth rejection tests in test_saved_views.py #2244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc46161
fix(tests): fix saved views auth rejection tests in test_saved_views.py
trivikramkalagi91-commits Jul 26, 2026
6dea4db
chore(deps): update postcss to resolve high-severity vulnerability bl…
trivikramkalagi91-commits Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 26 additions & 8 deletions testing/backend/unit/test_saved_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,19 +357,37 @@ async def test_filter_json_with_null_values_rejected(app_client: AsyncClient):
@pytest.mark.asyncio
async def test_unauthenticated_request_rejected(app_client: AsyncClient):
"""Requests without a valid API key/session are rejected, not served."""
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": ""}
)
assert res.status_code == 401
app = app_client.test_transport.app
orig_override = app.dependency_overrides.get(require_api_key)
if require_api_key in app.dependency_overrides:
del app.dependency_overrides[require_api_key]

try:
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": ""}
)
assert res.status_code == 401
finally:
if orig_override is not None:
app.dependency_overrides[require_api_key] = orig_override


@pytest.mark.asyncio
async def test_wrong_api_key_rejected(app_client: AsyncClient):
"""A malformed/incorrect API key is rejected."""
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": "not-the-real-key"}
)
assert res.status_code == 401
app = app_client.test_transport.app
orig_override = app.dependency_overrides.get(require_api_key)
if require_api_key in app.dependency_overrides:
del app.dependency_overrides[require_api_key]

try:
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": "not-the-real-key"}
)
assert res.status_code == 401
finally:
if orig_override is not None:
app.dependency_overrides[require_api_key] = orig_override


@pytest.mark.asyncio
Expand Down
Loading