fix(tests): restore require_api_key in saved_views auth rejection tests - #2062
Closed
SHAROZ221 wants to merge 1 commit into
Closed
fix(tests): restore require_api_key in saved_views auth rejection tests#2062SHAROZ221 wants to merge 1 commit into
SHAROZ221 wants to merge 1 commit into
Conversation
utksh1
requested changes
Jul 24, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
This branch includes the unrelated Windows documentation commit from #2060. Please rebase/split it so this PR contains only the saved-view authentication test repair, and add an assertion that the dependency override is restored after each negative-auth test.
utksh1
requested changes
Jul 24, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Please split the Windows-guide documentation commit into #2060 (or another docs PR). This PR should contain only the saved-views auth-test correction, plus a focused explanation of why the dependency override must be removed for these two negative tests.
SHAROZ221
force-pushed
the
fix/saved-views-auth-tests
branch
from
July 24, 2026 09:54
0a1da51 to
569c6a1
Compare
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes failing auth rejection unit tests in
testing/backend/unit/test_saved_views.py(test_unauthenticated_request_rejectedandtest_wrong_api_key_rejected).Because
app_clientfixture sets_app.dependency_overrides[require_api_key] = _mock_require_api_key, requests with empty or incorrect API keys were bypassing authentication and returning200 OKinstead of401 Unauthorized.This PR temporarily restores
require_api_keyfor those two auth rejection tests, bringingtest_saved_views.pyto 47/47 PASSED (100%).Contributed as part of GSSoC (GirlScript Summer of Code).
Related Issues
Fixes failing auth tests in
testing/backend/unit/test_saved_views.py.Type of Change
How Has This Been Tested?
Ran pytest directly on
testing/backend/unit/test_saved_views.py: