consoleの実装とテストをpackages/jsEval/に移動#226
Open
tknkaa wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
my-code | 5beebc9 | Commit Preview URL Branch Preview URL |
Jul 24 2026, 01:15 PM |
tknkaa
marked this pull request as draft
July 24, 2026 01:55
replのテストファイルにJS専用のconsole.time/timeEndテストが混在していたため、 consoleの実装(createReplConsole)をjsEval側に切り出し、対応するテストも移動した。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tknkaa
force-pushed
the
refactor/move-console-to-jseval
branch
from
July 24, 2026 13:10
2160682 to
5beebc9
Compare
tknkaa
marked this pull request as ready for review
July 24, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript だけのテストを REPL の共通テストファイルに書きたくない、という話があってのリファクタ PR です。
JavaScript の console のロジックを
createReplConsoleという関数に切り出し、@my-code/js-evalワークスペースに移動しました。それに伴い、@my-code/runtimeにあった JavaScript だけのテストも@my-code/js-evalに移動しました。