console.time / console.timeEnd を実装#225
Open
tknkaa wants to merge 2 commits into
Open
Conversation
console.time/timeEndは未実装のためワーカーグローバルの元のconsoleにフォールバックしており、 呼び出しても出力パネルに何も表示されなかった(#125)。 labelごとの開始時刻を記録し、timeEnd時に経過時間を出力するよう実装。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
my-code | c0488f8 | Commit Preview URL Branch Preview URL |
Jul 23 2026, 01:58 PM |
tknkaa
marked this pull request as draft
July 23, 2026 13:52
@testing-library/react が要求するpeer dependencyが宣言されておらず、 vitestの依存解決(esbuild)が失敗しCIのtest-runtimeジョブが実行前に落ちていた。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tknkaa
marked this pull request as ready for review
July 23, 2026 14:04
Contributor
|
na-trium-144
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#125 の console.time と console.timeEnd を実装し、テストを追加しました。console.log のフォーマット指定子については、現在のドキュメントでは使われていないため、いったんこの PR では実装していません。
また、テストについては、@testing-library/dom が @testing-library/react の peerDependency として要求されていたので、devDependencies に追加し、新しく追加したテストが通ることを確認しました。